Write Tests for class "ButtonNoteMaker"

Assets/Editor/ButtonNoteMakerTests.cs

+using TrackAnalysis;
+using NUnit.Framework;
+
+class ButtonNoteMakerTests
+{
+    [Test]
+    public void Made_Note_Should_Null_When_Invalid_Note_Type()
+    {
+        var obj = new ButtonNoteMaker();
+        var note = obj.Make("AA", "SMO", 0);
+
+        var expected = true;
+        var actual = (note == null);
+
+        Assert.AreEqual(expected, actual, "Made note should be null value when invalid note type");
+    }
+
+    [Test]
+    public void Made_Note_Should_Short_When_Note_Type_SBT()
+    {
+        var obj = new ButtonNoteMaker();
+        var note = obj.Make("AA", "SBT", 0);
+
+        var expected = true;
+        var actual = (note.Type == NoteType.SBT);
+
+        Assert.AreEqual(expected, actual, "Made note should be short when note type is SBT");
+    }
+
+    [Test]
+    public void Made_Note_Should_Long_When_Note_Type_LBT()
+    {
+        var obj = new ButtonNoteMaker();
+        var tmp  = obj.Make("AA", "LBT", 0);
+        var note = obj.Make("AA", "LBT", 1);
+
+        var expected = true;
+        var actual = (tmp       == null &&
+                      note.Type == NoteType.LBT);
+
+        Assert.AreEqual(expected, actual, "Made note should be long when note type is LBT");
+    }
+
+    [Test]
+    public void Short_Short_Should_Made_Correctly()
+    {
+        var obj = new ButtonNoteMaker();
+        var note1 = obj.Make("AA", "SBT", 0);
+        var note2 = obj.Make("AA", "SBT", 1);
+
+        var expected = true;
+        var actual = (note1.Type == NoteType.SBT &&
+                      note2.Type == NoteType.SBT);
+
+        Assert.AreEqual(expected, actual, "2 short notes should be made correctly");
+    }
+
+    [Test]
+    public void Short_Long_Should_Made_Correctly()
+    {
+        var obj = new ButtonNoteMaker();
+        var note1 = obj.Make("AA", "SBT", 0);
+        var tmp   = obj.Make("AA", "LBT", 1);
+        var note2 = obj.Make("AA", "LBT", 2);
+
+        var expected = true;
+        var actual = (note1.Type == NoteType.SBT &&
+                      note2.Type == NoteType.LBT);
+
+        Assert.AreEqual(expected, actual, "The short next long note should be made correctly");
+    }
+
+    [Test]
+    public void Long_Short_Should_Made_Correctly()
+    {
+        var obj = new ButtonNoteMaker();
+        var tmp = obj.Make("AA", "LBT", 0);
+        var note1 = obj.Make("AA", "LBT", 1);
+        var note2 = obj.Make("AA", "SBT", 2);
+
+        var expected = true;
+        var actual = (note1.Type == NoteType.LBT &&
+                      note2.Type == NoteType.SBT);
+
+        Assert.AreEqual(expected, actual, "The long next short note should be made correctly");
+    }
+
+    [Test]
+    public void Long_Long_Should_Made_Correctly()
+    {
+        var obj = new ButtonNoteMaker();
+        var tmp1  = obj.Make("AA", "LBT", 0);
+        var note1 = obj.Make("AA", "LBT", 1);
+        var tmp2  = obj.Make("AA", "LBT", 2);
+        var note2 = obj.Make("AA", "LBT", 3);
+
+        var expected = true;
+        var actual = (tmp1       == null         &&
+                      tmp2       == null         &&
+                      note1.Type == NoteType.LBT &&
+                      note2.Type == NoteType.LBT);
+
+        Assert.AreEqual(expected, actual, "2 long notes should be made correctly");
+    }
+}
\ No newline at end of file

Assets/Editor/ButtonNoteMakerTests.cs.meta

+fileFormatVersion: 2
+guid: 64c38a1c28876364bbc53494a083cd8a
+timeCreated: 1518212150
+licenseType: Free
+MonoImporter:
+  externalObjects: {}
+  serializedVersion: 2
+  defaultReferences: []
+  executionOrder: 0
+  icon: {instanceID: 0}
+  userData: 
+  assetBundleName: 
+  assetBundleVariant: 

Assets/JudgeModule/Judge.cs

+using System.Collections.Generic;
+using System.Linq;
+using UnityEngine;
+
+namespace JudgeModule
+{
+    public class Judge
+    {
+        public static readonly List<Judge> JudgeList = new List<Judge>
+        {
+            new Judge("PERFECT") { ButtonTimingRange = PerfectTime,  Score = 2, Color = Color.cyan },
+            new Judge("GOOD")    { ButtonTimingRange = GoodTime,     Score = 1, Color = Color.yellow },
+            new Judge("BAD")     { ButtonTimingRange = BadTime,                 Color = Color.blue, IsBreak = true },
+            new Judge("MISS")    { Color = Color.red, IsBreak = true }
+        };
+    
+        private Judge()
+        {
+            ButtonTimingRange = 0f;
+            Score = 0;
+            IsBreak = false;
+            Color = Color.black;
+        }
+    
+        private Judge(string name) : this() { Name = name; }
+    
+        public string Name { get; private set; }
+    
+        private const float PerfectTime = 80f,
+                            GoodTime    = 100f,
+                            BadTime     = 120f;
+    
+        public float ButtonTimingRange { get; private set; }
+        public int   Score { get; private set; }
+        public bool  IsBreak { get; private set; }
+        public Color Color { get; private set; }
+    
+        public static readonly Judge BAD = JudgeList[2];
+        public static readonly Judge MISS = JudgeList.Last();
+        public static readonly
+            float MaxButtonTimingRange = BadTime;
+    
+        public static Judge TestJudge(Note note, float elapsedTime, bool end = false, bool test = false)
+        {
+            float timing = end ? note.EndTiming : note.StartTiming;
+            float difference = elapsedTime - timing;
+    
+            if (test)
+                Debug.Log(difference);
+    
+            var result = JudgeList.Where(x => Mathf.Abs(difference) < x.ButtonTimingRange).ToList();
+    
+            return result.Count == 0 ? JudgeList.Last() : result[0];
+        }
+    
+        public static bool IsPastNote(Note note, float elapsedTime)
+        {
+            float timing = note.IsLong && note.Activated ? note.EndTiming : note.StartTiming;
+            return elapsedTime - timing > BadTime;
+        }
+    
+        public static bool IsNoteStart(Note note, float elapsedTime)
+        {
+            return note is MotionNote &&
+                   !note.Activated;
+        }
+    
+        public static bool IsNoteEnd(Note note, float elapsedTime)
+        {
+            return elapsedTime - note.EndTiming <= BadTime;
+        }
+    
+        public static bool IsNoteComboBroken(Judge judge)
+        {
+            return judge == BAD ||
+                   judge == MISS;
+        }
+    }
+}
\ No newline at end of file

Assets/Script/GameManager.cs

-using System.Collections.Generic;
+using JudgeModule;
+using System.Collections.Generic;
 using TrackAnalysis;
 using UnityEngine;
 using UnityEngine.SceneManagement;

Assets/Script/Judge.cs

-using System.Collections.Generic;
-using System.Linq;
-using UnityEngine;
-
-public class Judge
-{
-    public static readonly List<Judge> JudgeList = new List<Judge>
-    {
-        new Judge("PERFECT") { ButtonTimingRange = PerfectTime,  Score = 2, Color = Color.cyan },
-        new Judge("GOOD")    { ButtonTimingRange = GoodTime,     Score = 1, Color = Color.yellow },
-        new Judge("BAD")     { ButtonTimingRange = BadTime,                 Color = Color.blue, IsBreak = true },
-        new Judge("MISS")    { Color = Color.red, IsBreak = true }
-    };
-
-    private Judge()
-    {
-        ButtonTimingRange = 0f;
-        Score = 0;
-        IsBreak = false;
-        Color = Color.black;
-    }
-
-    private Judge(string name) : this() { Name = name; }
-
-    public string Name { get; private set; }
-
-    private const float PerfectTime = 80f,
-                        GoodTime    = 100f,
-                        BadTime     = 120f;
-
-    public float ButtonTimingRange { get; private set; }
-    public int   Score { get; private set; }
-    public bool  IsBreak { get; private set; }
-    public Color Color { get; private set; }
-
-    public static readonly Judge BAD = JudgeList[2];
-    public static readonly Judge MISS = JudgeList.Last();
-    public static readonly
-        float MaxButtonTimingRange = BadTime;
-
-    public static Judge TestJudge(Note note, float elapsedTime, bool end = false, bool test = false)
-    {
-        float timing = end ? note.EndTiming : note.StartTiming;
-        float difference = elapsedTime - timing;
-
-        if (test)
-            Debug.Log(difference);
-
-        var result = JudgeList.Where(x => Mathf.Abs(difference) < x.ButtonTimingRange).ToList();
-
-        return result.Count == 0 ? JudgeList.Last() : result[0];
-    }
-
-    public static bool IsPastNote(Note note, float elapsedTime)
-    {
-        float timing = note.IsLong && note.Activated ? note.EndTiming : note.StartTiming;
-        return elapsedTime - timing > BadTime;
-    }
-
-    public static bool IsNoteStart(Note note, float elapsedTime)
-    {
-        return note is MotionNote &&
-               !note.Activated;
-    }
-
-    public static bool IsNoteEnd(Note note, float elapsedTime)
-    {
-        return elapsedTime - note.EndTiming <= BadTime;
-    }
-
-    public static bool IsNoteComboBroken(Judge judge)
-    {
-        return judge == BAD ||
-               judge == MISS;
-    }
-}
\ No newline at end of file

Assets/Script/ScoreDisplayManager.cs

-using UnityEngine;
+using JudgeModule;
+using UnityEngine;
 using UnityEngine.UI;
 
 public class ScoreDisplayManager : MonoBehaviour