Write a test for the class "DistItvExtractor", "MotionDiscriminator"

Assets/Editor/DistItvExtractorTests.cs

+using MotionAnalysis;
+using NUnit.Framework;
+using System.Collections.Generic;
+using Windows.Kinect;
+
+public class DistItvExtractorTests
+{
+    [Test]
+    public void DistHandBaseSpineShoulder_Should_Null_When_Constructed()
+    {
+        var obj = new DistItvExtractor(0.0f);
+
+        var expected = null as float?;
+        var actual = obj.DistHandBaseSpineShoulder;
+
+        Assert.AreEqual(expected, actual, "DistHandBaseSpineShoulder should be null value when constructed");
+    }
+
+    [Test]
+    public void DistHandBaseSpineShoulder_Should_Not_Null_When_Update_Valid_Body()
+    {
+        var obj = new DistItvExtractor(0.0f);
+        obj.Extract(new ClapBasicBodyStub());
+
+        var expected = false;
+        var actual = (obj.DistHandBaseSpineShoulder == null);
+
+        Assert.AreEqual(expected, actual, "DistHandBaseSpineShoulder should not be null value when update with valid body");
+    }
+}
+
+public class ClapBasicBodyStub : BodyFake
+{
+    public ClapBasicBodyStub()
+    {
+        Joints = new Dictionary<JointType, KinectModule.IJoint>
+        {
+            { JointType.HandLeft,      new JointStub() },
+            { JointType.HandRight,     new JointStub() },
+            { JointType.SpineShoulder, new JointStub() }
+        };
+    }
+}
\ No newline at end of file

Assets/Editor/DistItvExtractorTests.cs.meta

+fileFormatVersion: 2
+guid: b69f0e35ef0ea2c4e8aaae5c1112237d
+timeCreated: 1518207677
+licenseType: Free
+MonoImporter:
+  externalObjects: {}
+  serializedVersion: 2
+  defaultReferences: []
+  executionOrder: 0
+  icon: {instanceID: 0}
+  userData: 
+  assetBundleName: 
+  assetBundleVariant: 

Assets/Editor/MotionDiscriminatorTests.cs

@@ -43,7 +43,7 @@ public class MotionDiscriminatorTests
     public void IsPreset_True_When_Preset_With_KneeJoints()
     {
         var obj = new MotionDiscriminator();
-        obj.Preset(new KneeJointsBodyStub());
+        obj.Preset(new KneeJointsBasicBodyStub());
 
         var expected = true;
         var actual = obj.IsPreseted;
@@ -54,7 +54,40 @@ public class MotionDiscriminatorTests
     [Test]
     public void Motion_Unknown_When_DistHandBaseSpineShoulder_Smaller_Than_0()
     {
-        
+        var obj = new MotionDiscriminator();
+        obj.Preset(new KneeJointsBasicBodyStub());
+        obj.Update(new ClapBodyStub_Unknown());
+
+        var expected = MotionState.UNKNOWN;
+        var actual = obj.Motion;
+
+        Assert.AreEqual(expected, actual, "Motion should be unknown when DistHandBaseSpineShoulder smaller than 0");
+    }
+
+    [Test]
+    public void Motion_ClapPrepare_When_ItvHand_Bigger_Than_itvPrepare()
+    {
+        var obj = new MotionDiscriminator();
+        obj.Preset(new KneeJointsBasicBodyStub());
+        obj.Update(new ClapBodyStub_Prepare());
+
+        var expected = MotionState.CLAP_PREPARE;
+        var actual = obj.Motion;
+
+        Assert.AreEqual(expected, actual, "Motion should be clap-prepare when ItvHand bigger than itvPrepare");
+    }
+
+    [Test]
+    public void Motion_ClapDone_When_ItvHand_Smaller_Than_itvDone()
+    {
+        var obj = new MotionDiscriminator();
+        obj.Preset(new KneeJointsBasicBodyStub());
+        obj.Update(new ClapBodyStub_Done());
+
+        var expected = MotionState.CLAP_DONE;
+        var actual = obj.Motion;
+
+        Assert.AreEqual(expected, actual, "Motion should be clap-done when ItvHand smaller than itvDone");
     }
 }
 
@@ -66,14 +99,53 @@ public class BodyDummy : BodyFake
     }
 }
 
-public class KneeJointsBodyStub : BodyFake
+public class KneeJointsBasicBodyStub : BodyFake
+{
+    public KneeJointsBasicBodyStub()
+    {
+        Joints = new Dictionary<JointType, KinectModule.IJoint>
+        {
+            { JointType.KneeLeft,  new JointStub() },
+            { JointType.KneeRight, new JointStub() }
+        };
+    }
+}
+
+public class ClapBodyStub_Unknown : BodyFake
+{
+    public ClapBodyStub_Unknown()
+    {
+        Joints = new Dictionary<JointType, KinectModule.IJoint>
+        {
+            { JointType.HandLeft,      new JointStub() },
+            { JointType.HandRight,     new JointStub() },
+            { JointType.SpineShoulder, new JointStub(y: 1) }
+        };
+    }
+}
+
+public class ClapBodyStub_Prepare : BodyFake
 {
-    public KneeJointsBodyStub()
+    public ClapBodyStub_Prepare()
     {
         Joints = new Dictionary<JointType, KinectModule.IJoint>
         {
-            { JointType.KneeLeft,      new JointStub() },
-            { JointType.KneeRight,     new JointStub() }
+            { JointType.HandLeft,      new JointStub() },
+            { JointType.HandRight,     new JointStub(x: MotionDiscriminator.itvPrepare + 1) },
+            { JointType.SpineShoulder, new JointStub(y: -1) }
         };
     }
 }
+
+public class ClapBodyStub_Done : BodyFake
+{
+    public ClapBodyStub_Done()
+    {
+        Joints = new Dictionary<JointType, KinectModule.IJoint>
+        {
+            { JointType.HandLeft,      new JointStub() },
+            { JointType.HandRight,     new JointStub(x: MotionDiscriminator.itvDone / 2) },
+            { JointType.SpineShoulder, new JointStub(y: -1) }
+        };
+    }
+}
\ No newline at end of file

Assets/Editor/SourceBufferTests.cs

@@ -331,12 +331,14 @@ public class BodyFake : IBody
 
 public class JointStub : IJoint
 {
+    public static float epsilon = 0.05f;
+
     public CameraSpacePoint Position
     { get; private set; }
 
-    public JointStub()
+    public JointStub(float x = 0f, float y = 0f, float z = 0f)
     {
-        Position = new CameraSpacePoint { X = 0, Y = 0, Z = 0 };
+        Position = new CameraSpacePoint { X = x, Y = y, Z = z };
     }
 
     public override bool Equals(object obj)
@@ -346,9 +348,19 @@ public class JointStub : IJoint
 
     public bool Equals(IJoint obj)
     {
-        return Math.Abs(Position.X - obj.Position.X) < 0.05 &&
-               Math.Abs(Position.Y - obj.Position.Y) < 0.05 &&
-               Math.Abs(Position.Z - obj.Position.Z) < 0.05;
+        return ComparePosition(Position, obj.Position);
+    }
+
+    public bool ComparePosition(CameraSpacePoint a, CameraSpacePoint b)
+    {
+        return CompareFloat(a.X, b.X) &&
+               CompareFloat(a.Y, b.Y) &&
+               CompareFloat(a.Z, b.Z);
+    }
+
+    private bool CompareFloat(float a, float b)
+    {
+        return Math.Abs(a - b) < epsilon;
     }
 
     public override int GetHashCode()

Assets/MotionAnalysis/DistItvExtractor.cs

@@ -82,7 +82,8 @@ namespace MotionAnalysis
     
         private void UpdatePosition(KinectModule.IBody body)
         {
-            Points.Keys.Select(x => (JointType)Enum.Parse(typeof(JointType), x))
+            Points.Keys.Where(x => !x.Contains("Recent"))
+                       .Select(x => (JointType)Enum.Parse(typeof(JointType), x))
                        .ToList()
                        .ForEach(x => Points[x.ToString()] =
                             body.Joints.ContainsKey(x) ?
@@ -141,9 +142,9 @@ namespace MotionAnalysis
 
             DistHandBaseSpineShoulder = Mathf.Min(handleft.Y, handright.Y) - spineshoulder.Y;
 
-            ItvHand                   = Mathf.Sqrt(Mathf.Pow(handleft.X - handright.X, 2.0f) +
-                                                   Mathf.Pow(handleft.Y - handright.Y, 2.0f) +
-                                                   Mathf.Pow(handleft.Z - handright.Z, 2.0f));
+            ItvHand                   = Mathf.Max(Mathf.Abs(handleft.X - handright.X),
+                                                  Mathf.Abs(handleft.Y - handright.Y),
+                                                  Mathf.Abs(handleft.Z - handright.Z));
         }
 
         private void ComputeJump()

Assets/MotionAnalysis/MotionDiscriminator.cs

@@ -12,7 +12,18 @@ namespace MotionAnalysis
         { get; private set; }
         public bool        IsPreseted
         { get; private set; }
-        
+
+        public const float itvPrepare  = 0.3f,
+                           itvDone     = 0.1f,
+                           distPrepare = 0.05f,
+                           distDone    = 0.0f,
+                           distBase    = 0.5f,
+                           distUp      = 0.2f,
+                           distJesus   = 0.5f,
+                           itvDepth    = 0.2f,
+                           itvEar      = 0.2f,
+                           distTable   = 0.5f;
+
         public void Preset(IBody body)
         {
             IsPreseted = false;
@@ -72,9 +83,6 @@ namespace MotionAnalysis
 
         private void Clap()
         {
-            const float itvPrepare = 0.3f,
-                        itvDone = 0.1f;
-
             if      (Extractor.DistHandBaseSpineShoulder <= 0.0f)
                 return;
 
@@ -86,9 +94,6 @@ namespace MotionAnalysis
 
         private void Jump()
         {
-            const float distPrepare = 0.05f,
-                        distDone = 0.0f;
-
             if      (Extractor.DistSpine < distPrepare)
                 Motion |= MotionState.JUMP_PREPARE;
             else if (Extractor.DistSpine > distDone)
@@ -116,8 +121,6 @@ namespace MotionAnalysis
 
         private void GuardBase()
         {
-            const float distBase = 0.5f;
-
             if      (Extractor.DistHandBaseElbow_Left > 0.0f &&
                      Extractor.ItvElbowBaseSpineMid_Left < distBase)
                 Motion |= MotionState.GUARD_BASE_LEFT;
@@ -129,8 +132,6 @@ namespace MotionAnalysis
 
         private void HandUp()
         {
-            const float distUp = 0.2f;
-
             if      (Extractor.DistHandBaseHead_Left > distUp)
                 Motion |= MotionState.HAND_UP_LEFT;
 
@@ -149,17 +150,12 @@ namespace MotionAnalysis
 
         private void Jesus()
         {
-            const float distJesus = 0.5f;
-
             if      (Extractor.DistHandBaseSpineShoulder > 0.0f && Extractor.ItvHandBaseHead >= distJesus)
                 Motion |= MotionState.JESUS;
         }
 
         private void Headphone()
         {
-            const float itvDepth = 0.2f,
-                        itvEar = 0.2f;
-
             if      (Extractor.ItvHandBaseHead_LeftEar < itvEar &&
                      Extractor.ItvHandBaseHead_LeftDepth < itvDepth)
                 Motion |= MotionState.HEADPHONE_LEFT;
@@ -171,8 +167,6 @@ namespace MotionAnalysis
 
         private void OnTheTable()
         {
-            const float distTable = 0.5f;
-
             if      (Extractor.DistKneeBaseTable >= distTable)
                 Motion |= MotionState.ON_THE_TABLE;
         }