notehit

RhythmKata/Assets/Scripts/Core/Note.cs

@@ -28,9 +28,12 @@ abstract class Note
 
     public abstract void Judge(double time);
 
+    // TODO: Refactort this
+    private static readonly float NOTE_SHOW_TIMING = 5;
+    private static readonly float NOTE_HIDE_TIMING = -2;
     public void Update(float remainingTime)
     {
-        if (remainingTime < -1 || remainingTime > 5)
+        if (remainingTime < NOTE_HIDE_TIMING || remainingTime > NOTE_SHOW_TIMING)
         {
             noteObject.gameObject.SetActive(false);
             Active = false;
@@ -40,7 +43,8 @@ abstract class Note
             Active = true;
             noteObject.gameObject.SetActive(true);
         }
-        noteObject.SetPosition(remainingTime);
+
+        noteObject.SetPosition(remainingTime/NOTE_SHOW_TIMING);
     }
 
     // factory method